Fix 0-byte reads/writes on blobs #36950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
reviewed
Oct 10, 2025
cincuranet
force-pushed
the
fix-0-rw-sqlite
branch
from
f22ee08 to
f892de4
Compare
roji
approved these changes
Oct 10, 2025
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Just checking - is this manifesting only on MacOS because a newer version of SQLite is being used there (i.e. by chance)?
Also, just noting that 0-reads (with TCP) are used as a way to ensure that the next read wouldn't block (i.e. that some amount of data has been received and is ready to be read synchronously). I don't think this is relevant for SQLite (as there's no networking involved), and in any case it seems that the SQLite APIs themselves don't support this.
Contributor
Author
Correct. |
This was referenced Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reason why macOS 15 tests are failing.